Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodbatlas_privatelink_endpoint_service data source doc bug fix #1334

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

Zuhairahmed
Copy link
Collaborator

@Zuhairahmed Zuhairahmed commented Jul 20, 2023

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.
Missing GCP as valid input per Atlas Admin API Docs: https://www.mongodb.com/docs/atlas/reference/api-resources-spec/v2/#tag/Private-Endpoint-Services/operation/createPrivateEndpoint

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@Zuhairahmed Zuhairahmed requested a review from a team as a code owner July 20, 2023 04:15
@Zuhairahmed Zuhairahmed changed the title Update privatelink_endpoint_service.html.markdown mongodbatlas_privatelink_endpoint_service data source doc bug fix Jul 20, 2023
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed merged commit 9380721 into master Jul 20, 2023
29 checks passed
@Zuhairahmed Zuhairahmed deleted the DocFix branch July 20, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants