Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add PR lint to repo #1348

Merged
merged 1 commit into from
Jul 27, 2023
Merged

ci: Add PR lint to repo #1348

merged 1 commit into from
Jul 27, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Jul 26, 2023

Description

Jira ticket: INTMDB-934

This PR adds a GitHub action to check that the PR follows Conventional Commits.
See CONTRIBUTING.md for a full list of available formats.

Summary of the format to use:

  • fix: description of the ticket: this correlates with PATCH in Semantic Versioning
  • feat: description of the ticket: this correlates with MINOR in Semantic Versioning
  • BREAKING CHANGE: a commit that has a footer BREAKING CHANGE: or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.
    Examples:
    • fix!: description of the ticket
    • If the PR has BREAKING CHANGE: in its description is a breaking change

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review July 26, 2023 10:37
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner July 26, 2023 10:37
@andreaangiolillo andreaangiolillo merged commit b727a42 into master Jul 27, 2023
17 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-934 branch July 27, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants