Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mark project api key resource as destroyed if not present #1351

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

AgustinBettati
Copy link
Member

Description

Ticket: INTMDB-918

Include missing logic to detect if project api key is not longer present during read operation.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

  • Included acceptance test to reproduce reported issue. Create project api key resource, delete externally using Atlas API, then expect terraform to detect resource needs to be recreated.

@AgustinBettati AgustinBettati requested a review from a team as a code owner July 27, 2023 08:49
@AgustinBettati AgustinBettati changed the title INTMDB-918: mark project api key resource as destroyed if not present fix: Mark project api key resource as destroyed if not present Jul 27, 2023
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AgustinBettati AgustinBettati merged commit bdd092a into master Jul 27, 2023
30 of 32 checks passed
@AgustinBettati AgustinBettati deleted the INTMDB-918 branch July 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants