Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate: marking cloud_provider_access resource and data source as deprecated #1355

Merged
merged 2 commits into from
Jul 31, 2023
Merged

deprecate: marking cloud_provider_access resource and data source as deprecated #1355

merged 2 commits into from
Jul 31, 2023

Conversation

AgustinBettati
Copy link
Member

Description

Ticket: INTMDB-967

Authorization for a cloud provider role using one resource path is deprecated in favor of two resource path approach.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@AgustinBettati AgustinBettati requested a review from a team as a code owner July 28, 2023 14:05
andreaangiolillo
andreaangiolillo approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick changes

@andreaangiolillo
Copy link
Collaborator

Feel free to merge the PR, failing tests are not related

@AgustinBettati AgustinBettati merged commit 50961d7 into master Jul 31, 2023
17 of 18 checks passed
@AgustinBettati AgustinBettati deleted the INTMDB-967 branch July 31, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AgustinBettati @andreaangiolillo