refactor: Migrate Resource: mongodbatlas_project to Terraform Plugin Framework and remove api_keys attribute #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maastha
changed the base branch from
master
to
CLOUDP-189585-plugin-framework-migration
…sts to use mux server with existing sdk v2 provider
…assume role schema
maastha
changed the base branch from
CLOUDP-189585-plugin-framework-migration
to
INTMDB-971
…sts to use mux server with existing sdk v2 provider
…assume role schema
maastha
commented
Aug 4, 2023
maastha
changed the title
10 tasks
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
andreaangiolillo
approved these changes
Aug 9, 2023
All project* acceptance tests passing. |
AgustinBettati
approved these changes
Aug 9, 2023
Zuhairahmed
reviewed
Aug 9, 2023
| @@ -0,0 +1,255 @@ | |||
| package mongodbatlas | |||
|
|
|||
There was a problem hiding this comment.
does "fw_" ahead of each of the file names stand for "framework"? if so suggest we call out somewhere in repo README file to let users know which resources / data sources have been migrated to new Terraform Plugin Framework
There was a problem hiding this comment.
@Zuhairahmed added to CONTRIBUTING.md
Zuhairahmed
approved these changes
Aug 9, 2023
Base automatically changed from
INTMDB-971
to
CLOUDP-189585-plugin-framework-migration
August 10, 2023 07:07
…rver with existing sdk v2 provider (#1366) * feat: define new framework provider, configure main and acceptance tests to use mux server with existing sdk v2 provider * fix ConflictsWith attribute validation and parsing of list values in assume role schema * refactor: addressing PR comments for linting and code cleanup * fix: define provider version in framework provider Metadata function * doc: add description for AWS Secrets Manager provider config attributes * refactor mux provider fractory method name and comments * doc: inlcude terraform version requirement in docs * refactor: remove redundant else statement * refactor: improve readability of methods in fw_provider + comments
…08-migrate-project
maastha
merged commit e4cfa54
into
CLOUDP-189585-plugin-framework-migration
18 checks passed
| resp.Diagnostics.Append(resp.State.Set(ctx, &projectPlanNew)...) | ||
| } | ||
|
|
||
| func (r *ProjectRS) Delete(ctx context.Context, req resource.DeleteRequest, resp *resource.DeleteResponse) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate Resource: mongodbatlas_project to Terraform Plugin Framework.
Link to any related issue(s): INTMDB-908
Type of change:
Required Checklist:
Further comments