Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed 1.12.0 deprecated fields. #1418

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Aug 28, 2023

Description

Removing all the fields that have been declared as to be deprecated in v1.12.0.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1015

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@marcosuma marcosuma requested a review from a team as a code owner August 28, 2023 07:39
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the documentation as well: https://github.com/mongodb/terraform-provider-mongodbatlas/tree/master/website/docs

r = resources and d = data sources

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM after reverting the removed acceptance tests.

Great work here 💯 !

One last action to do as part of this ticket is to add a list of deprecated fields per resource/datasource in the PR description (or in the JIRA ticket) to help us add this info in the CHANGELOG before the release.

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the test change. Would look into Andreas last comment before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants