Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: INTMDB-1017- Addressed follow up comment #1420

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix: INTMDB-1017- Addressed follow up comment #1420

merged 1 commit into from
Aug 28, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 28, 2023 •
edited
Loading

Description

This PR addresses this comment: #1419 (comment)

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo mentioned this pull request Aug 28, 2023
Merged
10 tasks
@andreaangiolillo andreaangiolillo marked this pull request as ready for review August 28, 2023 14:29
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 28, 2023 14:29
marcosuma
marcosuma approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you for getting back to it and update it 🙏

@andreaangiolillo andreaangiolillo merged commit a6d6b04 into master Aug 28, 2023
20 checks passed
@andreaangiolillo andreaangiolillo deleted the INTMDB-1017_follow_up branch August 28, 2023 15:37
andreaangiolillo added a commit that referenced this pull request Sep 7, 2023
@andreaangiolillo
fix: Addressed follow up comment (#1420)
801d4a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosuma marcosuma marcosuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andreaangiolillo @marcosuma