Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove 3rd shard from 2 shard global cluster example #1423

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

BassT
Copy link
Contributor

@BassT BassT commented Aug 28, 2023

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@BassT BassT requested a review from a team as a code owner August 28, 2023 18:29
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BassT,
Thank you for your contribution! Could you kindly provide some additional clarification regarding the changes made in your PR? Specifically, in the example provided, the definition outlines a scenario where there's a global cluster spanning across 2 zones, and within each zone, there are 3 shards.

@BassT
Copy link
Contributor Author

BassT commented Aug 29, 2023

Hi @andreaangiolillo,

The comment in line 61 suggests that "zone n2" is supposed to be a 2-shard zone but lists 3 shards.

"shard n3" in "zone n2" falls out of line because it's the only shard located in the US while the other two shards of this zone are located in Europe.

For the sake of clarity I suggest removing "shard n3" of "zone n2". Alternatively, the comment on "zone n2" could be changed to "3-shard Multi-Cloud Cluster" and the region of "shard n3" to one in Europe.

@andreaangiolillo
Copy link
Collaborator

I see, thanks for the clarification!

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 5667200 into mongodb:master Aug 29, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants