Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve cluster doc to highlight that provider_volume_type=STANDARD is not available for NVMW clusters #1430

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Aug 30, 2023

Description

This was discovered as part of a query in our internal hashicorp slack channel
Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@andreaangiolillo andreaangiolillo requested a review from a team as a code owner August 30, 2023 08:30
@andreaangiolillo andreaangiolillo changed the title doc: improve cluster doc to highlith that provider_volume_type=STANDARD is not available for NVMW clusters doc: improve cluster doc to highlight that provider_volume_type=STANDARD is not available for NVMW clusters Aug 30, 2023
@wtrocki
Copy link
Member

wtrocki commented Aug 30, 2023

Users will still get error with a similar message when they still try to use it?

@andreaangiolillo
Copy link
Collaborator Author

yes, there is a validation in the endpoint that will return an error. I created this ticket https://jira.mongodb.org/browse/CLOUDP-197623 to improve the open API doc of the endpoint as well

@wtrocki
Copy link
Member

wtrocki commented Aug 30, 2023

Awesome

@andreaangiolillo andreaangiolillo merged commit 819be8e into master Aug 30, 2023
20 checks passed
@andreaangiolillo andreaangiolillo deleted the fix_provider_volume_type_doc branch August 30, 2023 08:55
andreaangiolillo added a commit that referenced this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants