Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: Deletes resources and data sources that were announced to be removed in 1.12.0. #1503

Merged

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Oct 3, 2023

Description

There were some resources and data_sources that were declared as deprecated and to be removed in 1.12.0 - we are doing this as part of our next release 1.12.2.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@marcosuma marcosuma requested a review from a team as a code owner October 3, 2023 13:10
@marcosuma marcosuma marked this pull request as draft October 3, 2023 13:10
@marcosuma marcosuma changed the title Deletes resources and data sources that were announced to be removed in 1.12.0. deprecate: Deletes resources and data sources that were announced to be removed in 1.12.0. Oct 3, 2023
@marcosuma marcosuma marked this pull request as ready for review October 4, 2023 09:46
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 20%
Summary 3% (271 / 10279)

Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing comments

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosuma marcosuma merged commit 6d663e5 into master Oct 6, 2023
23 checks passed
@marcosuma marcosuma deleted the INTMDB-1147-delete-deprecated-res-and-ds-for-1.12.0 branch October 6, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants