fix: adjust format of database user resource id as defined in previous versions #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgustinBettati
force-pushed
the
INTMDB-1172
branch
from
bf7ae5a
to
77d2b69
Compare
|
andreaangiolillo
approved these changes
Oct 4, 2023
| @@ -391,9 +390,14 @@ func newTFDatabaseUserModel(ctx context.Context, model *tfDatabaseUserModel, dbU | |||
| return nil, diagnostic | |||
| } | |||
|
|
|||
| id := fmt.Sprintf("%s-%s-%s", dbUser.GroupID, dbUser.Username, dbUser.DatabaseName) | |||
| // ID is encoded to preserve format defined in previous versions. | |||
There was a problem hiding this comment.
Do we have to update splitDatabaseUserImportID at line 255? wondering if we are still able to use it
There was a problem hiding this comment.
that line is handling the case of importing the resource, the format in that case is {project_id}-{username}-{auth_database_name} and should not change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: INTMDB-1172
Format defined in
1.11.1: https://github.com/mongodb/terraform-provider-mongodbatlas/blob/v1.11.1/mongodbatlas/resource_mongodbatlas_database_user.go#L256Note: as of
1.12.xthere is no usage of the id value within the database user resource, so it can be modified safely back to the format defined in1.11.1.Type of change:
Required Checklist:
Further comments