Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Updates template issue with clearer guidelines. #1510

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Oct 6, 2023

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): Engineering Proposal

https://jira.mongodb.org/browse/CLOUDP-202434

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@marcosuma marcosuma changed the title Updates template issue with clearer guidelines. doc : Updates template issue with clearer guidelines. Oct 6, 2023
@marcosuma marcosuma changed the title doc : Updates template issue with clearer guidelines. doc: Updates template issue with clearer guidelines. Oct 6, 2023
Comment on lines 21 to 30
In order to follow the **"one-click reproducible issues" principle**, please follow these guidelines:
* We should be able to run `terraform plan` and `terraform apply` **with no errors**.
* Configurations that return errors when executed will be de-prioritised in favour of the ones that succeed.
* Share your configuration by **using variables**. Create a `variables.tf` file and share its content.
* Before opening an issue, you have to try to specifically isolate it to **Terraform MongoDB Atlas** provider by **removing as many dependencies** as possible. If the issue only happens with other dependencies, then:
* If other terraform providers are required, please make sure you also include those. Same "one-click reproducible issue" principle applies.
* If external components are required to replicate it, please make sure you also provides instructions on those parts.

* If the issue requires **changes from the UI**, please document them preferably with screenshots
* If the issue involves **version changes** (e.g. `run plan with version 1.k.x then re-run with version 1.k.y`), please make sure you report the detailed sequence on commands to execute.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list is missing the following info:
- Terraform Atlas provider version used to reproduce the issue
- Terraform version used to reproduce the issue
- Confirmation if Terraform OSS, Terraform Cloud, or Terraform Enterprise deployment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding:

- Terraform Atlas provider version used to reproduce the issue
- Terraform version used to reproduce the issue

maybe we can clarify that the version.tf file is also needed (i.e. the provider specification).
I think I specified somewhere else that the whole configuration is needed in order for us to be one-click-away from reproducing the issue; but I'll clarify that.

- Confirmation if Terraform OSS, Terraform Cloud, or Terraform Enterprise deployment

Ok sure, this one I missed it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes updated. Let me know if that's ok with you.

.github/ISSUE_TEMPLATE/Bug_Report.md Outdated Show resolved Hide resolved
marcosuma and others added 2 commits October 14, 2023 18:53
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
@marcosuma marcosuma marked this pull request as ready for review October 16, 2023 06:01
@marcosuma marcosuma requested a review from a team as a code owner October 16, 2023 06:01
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a small comment

.github/ISSUE_TEMPLATE/Bug_Report.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/Bug_Report.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

General feedback (no changes are needed, I'm happy to see if the current template works before making any changes): I think the template is too verbose as a user may not want to read all of this info before opening an issue. In the future, we might consider a more concise template that lists the top 3-4 pieces of information users must provide when opening an issue.

marcosuma and others added 3 commits October 16, 2023 12:59
Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>
Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 12%
Summary 3% (271 / 10290)

@marcosuma
Copy link
Collaborator Author

@AgustinBettati updated with your corrections. Thank you!

@andreaangiolillo I agree with your comment, I think too it's verbose but I am not sure if in this specific case it's a problem.
My rationale is that I consider these instructions like the "Terms & Conditions" that you have when "signing contracts". It's not exactly the same of course but the similarity is that in both cases we acknowledge it's a long text we have to read because we must make sure we write all the necessary information in order to be able to "push back" whenever needed. On the contrary, if we don't write things we'll never be able to ask for something.

This is my rationale. I don't expect actually all users will read it all, but when they don't comply to our guidelines from now on we'll be able to claim that the issue is not ready to be worked. At some point the most frequent issue creators will know our new guidelines.

FYI @andreaangiolillo @AgustinBettati I made few other changes or restructuring it.

@marcosuma marcosuma merged commit b581d84 into master Oct 16, 2023
19 checks passed
@marcosuma marcosuma deleted the update-template-issue branch October 16, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants