feat: set format for AWS region value in the provider definition

mongodbatlas/fw_provider.go

@@ -21,6 +21,7 @@ import (
 	sdkv2schema "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
 	cstmvalidator "github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator"
+	"github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util"
 	"github.com/mongodb/terraform-provider-mongodbatlas/version"
 )
 
@@ -221,7 +222,7 @@ func (p *MongodbtlasProvider) Configure(ctx context.Context, req provider.Config
 	if awsRoleDefined {
 		config.AssumeRole = parseTfModel(ctx, &assumeRoles[0])
 		secret := data.SecretName.ValueString()
-		region := data.Region.ValueString()
+		region := util.MongoDBRegionToAWSRegion(data.Region.ValueString())
 		awsAccessKeyID := data.AwsAccessKeyID.ValueString()
 		awsSecretAccessKey := data.AwsSecretAccessKeyID.ValueString()
 		awsSessionToken := data.AwsSessionToken.ValueString()

mongodbatlas/provider.go

@@ -25,6 +25,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
+	"github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util"
 	"github.com/mwielbut/pointy"
 	"github.com/spf13/cast"
 	"github.com/zclconf/go-cty/cty"
@@ -271,7 +272,7 @@ func providerConfigure(ctx context.Context, d *schema.ResourceData) (any, diag.D
 	if awsRoleDefined {
 		config.AssumeRole = expandAssumeRole(assumeRoleValue.([]any)[0].(map[string]any))
 		secret := d.Get("secret_name").(string)
-		region := d.Get("region").(string)
+		region := util.MongoDBRegionToAWSRegion(d.Get("region").(string))
 		awsAccessKeyID := d.Get("aws_access_key_id").(string)
 		awsSecretAccessKey := d.Get("aws_secret_access_key").(string)
 		awsSessionToken := d.Get("aws_session_token").(string)

mongodbatlas/util/type_conversion.go

@@ -1,6 +1,9 @@
 package util
 
-import "time"
+import (
+	"strings"
+	"time"
+)
 
 func SafeString(s *string) string {
 	if s != nil {
@@ -48,3 +51,8 @@ func IntPtrToInt64Ptr(i *int) *int64 {
 func IsStringPresent(strPtr *string) bool {
 	return strPtr != nil && len(*strPtr) > 0
 }
+
+// MongoDBRegionToAWSRegion converts region in US_EAST_1-like format to us-east-1-like
+func MongoDBRegionToAWSRegion(region string) string {
+	return strings.ReplaceAll(strings.ToLower(region), "_", "-")
+}

mongodbatlas/util/type_conversion_test.go

@@ -50,3 +50,20 @@ func TestIsStringPresent(t *testing.T) {
 		}
 	}
 }
+
+func TestMongoDBRegionToAWSRegion(t *testing.T) {
+	tests := []struct {
+		region   string
+		expected string
+	}{
+		{"US_EAST_1", "us-east-1"},
+		{"us-east-1", "us-east-1"},
+		{"nothing", "nothing"},
+	}
+
+	for _, test := range tests {
+		if resp := util.MongoDBRegionToAWSRegion(test.region); resp != test.expected {
+			t.Errorf("MongoDBRegionToAWSRegion(%v) = %v; want %v", test.region, resp, test.expected)
+		}
+	}
+}