feat: adds more environment variables to be used when authenticating with an AWS Role #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosuma
changed the title
lantoli
reviewed
Oct 25, 2023
lantoli
approved these changes
Oct 25, 2023
AgustinBettati
approved these changes
Oct 25, 2023
…B-1034-set-all-default-values
AgustinBettati
approved these changes
Oct 25, 2023
lantoli
reviewed
Oct 26, 2023
lantoli
reviewed
Oct 26, 2023
* adds test coverage. * pre-check that regular credentials env variables are not set. * feat: adds test infrastructure to run acceptance tests on PRs (#1553) * adds test infra. * fix.
Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
lantoli
reviewed
Oct 26, 2023
|
marcosuma
merged commit 2d4d28f
into
INTMDB-1034-fix-aws-region-env-variable-bug
21 checks passed
marcosuma
added a commit
that referenced
this pull request
Oct 30, 2023
* fixed region value when creating configuration for aws role authentication. * restore go.mod and go.sum. * separates logic into util func. * feat: adds more environment variables to be used when authenticating with an AWS Role (#1551) * set all possible default values taken from environment varialbes (if exist). * addresses comments. * feat: adds test coverage for AWS Role Authentication (#1552) * adds test coverage. * pre-check that regular credentials env variables are not set. * feat: adds test infrastructure to run acceptance tests on PRs (#1553) * adds test infra. * fix. * Update mongodbatlas/provider.go Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * Update mongodbatlas/provider.go Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> * addresses comments. --------- Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com> --------- Co-authored-by: Leo Antoli <430982+lantoli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two more environment variables ASSUME_ROLE_ARN and SECRET_NAME as values from which it is possible to set a default in the provider configuration (to be used for AWS Role-based authentication).
Related to: https://jira.mongodb.org/browse/INTMDB-1034
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments