Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: documentation errors in cloud provider access #1615

Merged

Conversation

milh0use
Copy link
Contributor

Description

First commit - fixes to typos and syntax errors in documentation
Second commit - suggested extra information to help customers translate the well documented Atlas Console method of cloud integrations with the sparsely documented Terraform method.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@milh0use milh0use requested a review from a team as a code owner November 10, 2023 09:52
@milh0use milh0use changed the title Milh0use/fix documentation errors doc: Milh0use/fix documentation errors Nov 10, 2023
Copy link
Collaborator

@jwilliams-mongo jwilliams-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@milh0use LGTM % some tiny tweaks

website/docs/r/cloud_provider_access.markdown Outdated Show resolved Hide resolved
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small consideration, all other changes LGTM. Thanks!

website/docs/r/cloud_provider_access.markdown Outdated Show resolved Hide resolved
milh0use and others added 2 commits November 13, 2023 13:52
Co-authored-by: John Williams <55147273+jwilliams-mongo@users.noreply.github.com>
Co-authored-by: Agustin Bettati <bettatiagustin@gmail.com>
@AgustinBettati AgustinBettati changed the title doc: Milh0use/fix documentation errors doc: documentation errors in cloud provider access Nov 15, 2023
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch @milh0use! LGTM on your PR and have confirmed that you have signed our contributor's agreement. Thanks again!

@AgustinBettati AgustinBettati merged commit 6437868 into mongodb:master Nov 15, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants