Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates PR template for further verifications. #1628

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Nov 15, 2023

Description

Updates our PR template and adds a required checklist to verify there are no credentials-related unsafe changes.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1290

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/testutils 37%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17%
Summary 3% (279 / 10320)

@marcosuma marcosuma marked this pull request as ready for review November 15, 2023 13:34
@marcosuma marcosuma requested a review from a team as a code owner November 15, 2023 13:34
@marcosuma marcosuma merged commit 9ee2da8 into master Nov 16, 2023
30 checks passed
@marcosuma marcosuma deleted the INTMDB-1290-update-pr-template branch November 16, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants