Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles attributes as computed. #1642

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Nov 20, 2023

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1308

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@github-actions github-actions bot added the bug label Nov 20, 2023
@marcosuma
Copy link
Collaborator Author

Tests are failing for unrelated changes:

--- FAIL: TestAccClusterRSCluster_basicAzure (756.29s)
...
--- FAIL: TestAccClusterRSCluster_AzureUpdateToNVME (838.13s)

@marcosuma marcosuma marked this pull request as ready for review November 21, 2023 11:53
@marcosuma marcosuma requested a review from a team as a code owner November 21, 2023 11:53
@marcosuma
Copy link
Collaborator Author

I also executed the manual test that the TSE highlighted here

Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 3%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/testutils 46%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 17%
Summary 3% (328 / 10541)

@marcosuma marcosuma merged commit f628755 into master Nov 21, 2023
27 of 28 checks passed
@marcosuma marcosuma deleted the HELP-52423-JPMC-old-tf-version branch November 21, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants