chore: project resource migration to new sdk #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
Nov 30, 2023
gssbzn
reviewed
Nov 30, 2023
gssbzn
reviewed
Nov 30, 2023
gssbzn
reviewed
Nov 30, 2023
gssbzn
reviewed
Nov 30, 2023
Comment on lines
-150
to
-153
| options := &matlas.ListOptions{ | ||
| PageNum: int(stateModel.PageNum.ValueInt64()), | ||
| ItemsPerPage: int(stateModel.ItemsPerPage.ValueInt64()), | ||
| } |
There was a problem hiding this comment.
any reason to ignore pagination now?
There was a problem hiding this comment.
With new SDK, ListProjects uses default values for pagination instead of the values from stateModel. Fixed it so I don't change the behaviour. Thanks!
There was a problem hiding this comment.
the old SDK should've had defaults as well, reason to ask is I have no context where stateModel was and if those values where meaningful
lantoli
reviewed
Dec 1, 2023
| results := make([]*tfProjectDSModel, 0, len(projectsRes.Results)) | ||
| for _, project := range projectsRes.Results { | ||
| atlasTeams, atlasLimits, atlasProjectSettings, err := getProjectPropsFromAPI(ctx, conn, connV2, project.ID) | ||
| for i, project := range projectsRes.Results { |
There was a problem hiding this comment.
i think it's better not to mix index and object in the loop, so in this case I recommend:
for i := range projectsRes.Results {
project := &projectsRes.Results[i]
...
There was a problem hiding this comment.
I don't have a strong opinion on this, but I am curious about why we should not mix object and index?
lantoli
reviewed
Dec 1, 2023
lantoli
reviewed
Dec 1, 2023
lantoli
reviewed
Dec 1, 2023
lantoli
reviewed
Dec 1, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
projectresource to new SDKLink to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-213827
Type of change:
Required Checklist:
Further comments