feat: Migrates some resources to new file structure #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaangiolillo
approved these changes
Dec 4, 2023
| @@ -14,7 +14,7 @@ import ( | |||
| matlas "go.mongodb.org/atlas/mongodbatlas" | |||
| ) | |||
|
|
|||
| func DataSourceAdvancedClusters() *schema.Resource { | |||
| func PluralDataSource() *schema.Resource { | |||
There was a problem hiding this comment.
(not blocking) Interesting name 🤔 What do you think about DataSources instead?
Suggested change
| func PluralDataSource() *schema.Resource { | |
| func DataSources() *schema.Resource { |
There was a problem hiding this comment.
I'm following what @AgustinBettati started, not a strong opinion to either
| @@ -186,12 +192,12 @@ func getDataSourcesMap() map[string]*schema.Resource { | |||
|
|
|||
| func getResourcesMap() map[string]*schema.Resource { | |||
| resourcesMap := map[string]*schema.Resource{ | |||
| "mongodbatlas_advanced_cluster": advancedcluster.ResourceAdvancedCluster(), | |||
| "mongodbatlas_advanced_cluster": advancedcluster.Resource(), | |||
There was a problem hiding this comment.
Do you need to update the github actions with the new path?
|
lantoli
commented
Dec 4, 2023
| @@ -3,7 +3,7 @@ name: 'Test Suite' | |||
| on: | |||
| workflow_dispatch: | |||
| schedule: | |||
| - cron: "0 2 * * *" # workflow runs every day at 02:00 AM | |||
| - cron: "0 0 * * *" # workflow runs every day at midnight UTC | |||
lantoli
commented
Dec 4, 2023
| @@ -18,7 +18,7 @@ jobs: | |||
| max-parallel: 1 | |||
| fail-fast: false | |||
| matrix: | |||
| terraform_version: ['', '1.1.6', '1.0.8'] # '' for latest version | |||
| terraform_version: ['', '1.0.8'] # '' for latest version | |||
There was a problem hiding this comment.
we already have the data for 1.1.6, removed to decrease time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates some resources to new file structure:
Type of change:
Required Checklist:
Further comments