feat: new mongodbatlas_stream_connection and mongodbatlas_stream_connections data sources
#1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
12 tasks
Base automatically changed from
CLOUDP-215322-avoid-depending-on-existing-proj
to
CLOUDP-215322
December 15, 2023 09:20
AgustinBettati
force-pushed
the
CLOUDP-215323
branch
2 times, most recently
from
366b531
to
7ce5f8d
Compare
AgustinBettati
commented
Dec 15, 2023
|
|
||
|
|
||
| To learn more, see: [MongoDB Atlas API - Stream Connection](https://www.mongodb.com/docs/atlas/reference/api-resources-spec/#tag/Streams/operation/getStreamConnection) Documentation. | ||
| The [Terraform Provider Examples Section](https://github.com/mongodb/terraform-provider-mongodbatlas/blob/master/examples/atlas-streams/README.md) also contains details on the overall support for Atlas Streams in Terraform. |
There was a problem hiding this comment.
referenced README file is defined in #1752
andreaangiolillo
approved these changes
Dec 15, 2023
|
|
||
| func TestAccStreamDSStreamConnection_kafkaPlaintext(t *testing.T) { | ||
| var ( | ||
| orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") |
There was a problem hiding this comment.
[nit] not need to address it here. I am wondering if we should define MONGODB_ATLAS_ORG_ID and other env vars in a common file and then import them. In this way, if we change the env var we just need to update it in one place.
There was a problem hiding this comment.
could remove some boilerplate for sure, on the other hand it does help to see want env variables are being used for each test so dont have a strong opinion
| CheckDestroy: CheckDestroyStreamConnection, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: streamConnectionsDataSourceConfig(kafkaStreamConnectionConfig(orgID, projectName, instanceName, "user", "rawpassword", "localhost:9092,localhost:9092", "earliest", false)), |
There was a problem hiding this comment.
[q - not blocking] Since all the data source tests use a resource. Couldn't we just have one acceptance test file where we have data source and resource test together? I see how this would decrease the amount of resources that we need to run the acceptance tests.
There was a problem hiding this comment.
It is a good point, I did go for this option in the case of search_deployment resource as execution times were quite long.
For this case the creation/update/delete of instance connections is very fast, so saw no harm in leaving in separate tests. One test case, Cluster connection type, does require creating a cluster but when running locally you can reference existing an existing cluster using env variables.
| @@ -0,0 +1,57 @@ | |||
| --- | |||
There was a problem hiding this comment.
Do we need to add a new example in the example folder?
lantoli
reviewed
Dec 15, 2023
lantoli
approved these changes
Dec 15, 2023
AgustinBettati
force-pushed
the
CLOUDP-215323
branch
from
7ce5f8d
to
c5ec932
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to any related issue(s): CLOUDP-215323
Includes unit testing, acceptance tests, and documentation.
Type of change:
Required Checklist:
Further comments