chore: Updates search_deployment resource with new SDK #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
force-pushed
the
CLOUDP-222717_search_deployment
branch
from
bd227e4
to
38d0749
Compare
lantoli
commented
Jan 21, 2024
| @@ -56,11 +56,3 @@ func IsStringPresent(strPtr *string) bool { | |||
| func MongoDBRegionToAWSRegion(region string) string { | |||
| return strings.ReplaceAll(strings.ToLower(region), "_", "-") | |||
| } | |||
|
|
|||
| // NonEmptyToPtr accepts an array or slice and returns a pointer to it, except if it's empty, in that case it returns nil. | |||
| func NonEmptyToPtr[T any](v []T) *[]T { | |||
lantoli
commented
Jan 21, 2024
| @@ -251,7 +251,7 @@ func TestProjectDataSourceSDKToResourceTFModel(t *testing.T) { | |||
| project: &projectSDK, | |||
| projectProps: project.AdditionalProperties{ | |||
| Teams: &admin.PaginatedTeamRole{ | |||
| Results: conversion.NonEmptyToPtr(teamRolesSDK), | |||
| Results: &teamRolesSDK, | |||
lantoli
force-pushed
the
CLOUDP-222717_search_deployment
branch
from
aa0663d
to
1b0f560
Compare
lantoli
commented
Jan 22, 2024
| @@ -237,7 +237,7 @@ func TestAccConfigRSAlertConfiguration_withThresholdUpdated(t *testing.T) { | |||
| ImportStateIdFunc: importStateProjectIDFunc(resourceName), | |||
| ImportState: true, | |||
| ImportStateVerify: true, | |||
| ImportStateVerifyIgnore: []string{"project_id", "matcher.0.field_name"}, | |||
| ImportStateVerifyIgnore: []string{"project_id", "updated", "matcher.0.field_name"}, | |||
There was a problem hiding this comment.
add "updated" to fix flaky test as sometimes updated time differs in a second
| "github.com/mongodb/terraform-provider-mongodbatlas/internal/testutil/mig" | ||
| ) | ||
|
|
||
| func TestAccMigrationSearchDeployment_basic(t *testing.T) { |
There was a problem hiding this comment.
I would keep into account that we also have the file data_source_search_deployment_schema.go, so changing the resource schema file to schema_search_deployment.go can cause confusion.
There was a problem hiding this comment.
i missed that, ok I'll revert the rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates search_deployment resource with new SDK.
Link to any related issue(s): https://jira.mongodb.org/browse/CLOUDP-222717
Type of change:
Required Checklist:
Further comments