Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates Atlas Go SDK #1856

Merged
merged 2 commits into from Jan 19, 2024
Merged

chore: Updates Atlas Go SDK #1856

merged 2 commits into from Jan 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automatic update for MongoDB Atlas Go Client SDK

@github-actions github-actions bot requested a review from a team as a code owner January 19, 2024 08:18
@AgustinBettati
Copy link
Collaborator

Must not be merged until manual adjustments are made to preserve 2 versions of SDK

@@ -227,7 +227,7 @@ func dataSourceMongoDBAtlasFederatedSettingsIdentityProvidersRead(ctx context.Co
return diag.Errorf("error getting federatedSettings IdentityProviders assigned (%s): %s", federationSettingsID, err)
}

if err := d.Set("results", FlattenFederatedSettingsIdentityProvider(federatedSettingsIdentityProviders)); err != nil {
if err := d.Set("results", FlattenFederatedSettingsIdentityProvider(federatedSettingsIdentityProviders.GetResults())); err != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected change coming from https://jira.mongodb.org/browse/CLOUDP-222481

Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing it

@AgustinBettati AgustinBettati merged commit 5714a27 into master Jan 19, 2024
33 checks passed
@AgustinBettati AgustinBettati deleted the atlas-sdk-update branch January 19, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants