Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades x509authentication_database_user resource to auto-generated SDK #1884

Merged
merged 9 commits into from Feb 5, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jan 30, 2024

Description

Upgrades x509authentication_database_user resource to auto-generated SDK.

Data source acceptance tests added.

Migration tests created.

Link to any related issue(s): CLOUDP-226094

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli force-pushed the CLOUDP-226094_x509authentication_database_user branch 4 times, most recently from 3a4c364 to 8eafb43 Compare February 2, 2024 10:53
@lantoli lantoli force-pushed the CLOUDP-226094_x509authentication_database_user branch from 8eafb43 to 32cdf64 Compare February 2, 2024 10:55
@lantoli lantoli marked this pull request as ready for review February 2, 2024 17:18
@lantoli lantoli requested a review from a team as a code owner February 2, 2024 17:18
Copy link
Collaborator

@oarbusi oarbusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lantoli lantoli merged commit e322ab9 into master Feb 5, 2024
40 checks passed
@lantoli lantoli deleted the CLOUDP-226094_x509authentication_database_user branch February 5, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants