Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Converts snapshot_id field from required to optional. #1924

Merged
merged 8 commits into from Feb 15, 2024

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Feb 8, 2024

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): CLOUDP-228582

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@github-actions github-actions bot added the bug label Feb 8, 2024
Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Feb 14, 2024
@marcosuma marcosuma added not_stale Not stale issue or PR and removed stale labels Feb 15, 2024
@marcosuma marcosuma marked this pull request as ready for review February 15, 2024 07:32
@marcosuma marcosuma requested a review from a team as a code owner February 15, 2024 07:32
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Oriol <oriol.abadal@mongodb.com>
@marcosuma marcosuma merged commit 8952761 into master Feb 15, 2024
46 checks passed
@marcosuma marcosuma deleted the CLOUDP-228582-snapshot-id branch February 15, 2024 15:28
lantoli added a commit that referenced this pull request Feb 16, 2024
* master:
  fix: Fixes timeout and removes deletion logic on update failure for mongodbatlas_search_index resource (#1950)
  task: remove dependency on pointy (#1953)
  fix: Converts snapshot_id field from required to optional. (#1924)

# Conflicts:
#	internal/service/cluster/resource_cluster.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants