chore: Upgrades cluster_outage_simulation resource to auto-generated SDK
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
reviewed
Feb 12, 2024
internal/service/clusteroutagesimulation/data_source_cluster_outage_simulation_test.go
Outdated
Show resolved
Hide resolved
lantoli
reviewed
Feb 12, 2024
| return fmt.Errorf(errorClusterOutageSimulationSetting, "state", err) | ||
| } | ||
| if err := d.Set("start_request_date", outageSimulation.StartRequestDate); err != nil { | ||
| if err := d.Set("start_request_date", conversion.TimeToString(outageSimulation.GetStartRequestDate())); err != nil { |
There was a problem hiding this comment.
Suggested change
| if err := d.Set("start_request_date", conversion.TimeToString(outageSimulation.GetStartRequestDate())); err != nil { | |
| if err := d.Set("start_request_date", conversion.TimePtrToStringPtr(outageSimulation.StartRequestDate)); err != nil { |
I you look at TimeToString implementation it will fail (or render a weird time) if it's nil, better to work with the pointer function
There was a problem hiding this comment.
I think it will panic because UTC doesn't check nil:
// UTC returns t with the location set to UTC.
func (t Time) UTC() Time {
t.setLoc(&utcLoc)
return t
}
There was a problem hiding this comment.
Thanks for noticing, changed to use TimePtrToStringPtr
lantoli
approved these changes
Feb 12, 2024
lantoli
reviewed
Feb 13, 2024
| @@ -69,14 +69,14 @@ func TestAccOutageSimulationClusterDS_MultiRegion_basic(t *testing.T) { | |||
| func dataSourceConfigSingleRegion(projectName, orgID, clusterName string) string { | |||
| return fmt.Sprintf(` | |||
| resource "mongodbatlas_project" "outage_project" { | |||
| name = "%s" | |||
| org_id = "%s" | |||
| name = %[1]q | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades
cluster_outage_simulationresource to auto-generated SDKAdd migration test
Link to any related issue(s): CLOUDP-226079
Type of change:
Required Checklist:
Further comments