Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoids skipping stream resources in qa tests #1959

Merged
merged 1 commit into from Mar 1, 2024

Conversation

AgustinBettati
Copy link
Collaborator

@AgustinBettati AgustinBettati commented Feb 19, 2024

Description

Context: Streams test group was being skipped in QA because Atlas Streams functionality could only be used when requesting activation for specific projects (this was not the case for dev). Atlas Streams is now in public preview and can be used freely therefor the streams test group can be included in QA acceptance tests.

Manual trigger to verify streams resource run successfully in QA: https://github.com/mongodb/terraform-provider-mongodbatlas/actions/runs/7963715855

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Feb 25, 2024
@AgustinBettati AgustinBettati added not_stale Not stale issue or PR and removed stale labels Feb 26, 2024
@AgustinBettati AgustinBettati marked this pull request as ready for review March 1, 2024 10:47
@AgustinBettati AgustinBettati requested a review from a team as a code owner March 1, 2024 10:47
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AgustinBettati AgustinBettati merged commit 42c5e28 into master Mar 1, 2024
73 checks passed
@AgustinBettati AgustinBettati deleted the run-streams-group-in-qa branch March 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants