Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates Atlas Go SDK and unifies resource prefix names in tests #1966

Merged
merged 13 commits into from Feb 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automatic update for MongoDB Atlas Go Client SDK

@lantoli
Copy link
Member

lantoli commented Feb 21, 2024

WORKING ON IT, PLEASE DONT MERGE

@lantoli lantoli changed the title chore: Updates Atlas Go SDK chore: Updates Atlas Go SDK and unifies resource prefix names in tests Feb 21, 2024
Copy link
Collaborator

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice additional cleanups 👌

@@ -6,8 +6,6 @@ linters-settings:
- opinionated
- performance
- style
disabled-checks:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why these linter settings are being modified

Copy link
Member

@lantoli lantoli Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reviewed and removed linter exceptions that are not relevant any more. at the end the fewer linter exceptions we have the better, they were for old code that doesn't exist now.

* master:
  chore: Upgrades `cloud_backup_schedule` resource to auto-generated SDK (#1946)
@github-actions github-actions bot added the bug label Feb 21, 2024
@lantoli lantoli merged commit 27a3486 into master Feb 21, 2024
40 of 44 checks passed
@lantoli lantoli deleted the atlas-sdk-update branch February 21, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants