Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Correct reference to cluster attribute auto_scaling_disk_gb_enabled #1983

Conversation

SimonPerryman
Copy link
Contributor

@SimonPerryman SimonPerryman commented Mar 1, 2024

Description

Currently in the basic cluster documentation there is a warning about ignoring changes in the terraform lifecycle when disk_gb_enabled is enabled. However, that is the attribute name for the advanced cluster, not the basic cluster. I've fixed the reference in the warning message to reference the attribute name of the basic cluster attribute..

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@SimonPerryman SimonPerryman requested a review from a team as a code owner March 1, 2024 11:47
@SimonPerryman SimonPerryman changed the title docs: Correct reference to cluster attribute auto_scaling_disk_gb_enabled doc: Correct reference to cluster attribute auto_scaling_disk_gb_enabled Mar 1, 2024
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 💯

@andreaangiolillo andreaangiolillo merged commit deac25e into mongodb:master Mar 1, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants