Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Schedules run of acceptance and migration tests for all HashiCorp Terraform supported versions #2012

Merged
merged 44 commits into from Mar 15, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Mar 12, 2024

Description

Schedule run of acceptance and migration tests for all supported versions of HashiCorp Terraform
Example Run (failed because it was manually cancelled to avoid consuming too many resources)

Link to any related issue(s): CLOUDP-219140

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@oarbusi oarbusi changed the title feat: schedule run of acceptance and migration tests for all HashiCorp Terraform supported versions feat: Schedules run of acceptance and migration tests for all HashiCorp Terraform supported versions Mar 12, 2024
@oarbusi oarbusi marked this pull request as ready for review March 14, 2024 15:36
@oarbusi oarbusi requested a review from a team as a code owner March 14, 2024 15:36

on:
schedule:
- cron: "0 0 * * 6" # runs every Saturady at midnight UTC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we're doing it weekly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this before putting it in review. Now it's fixed, will run on first Saturday of every month

.github/workflows/terraform-compatibility-matrix.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-compatibility-matrix.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-compatibility-matrix.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-compatibility-matrix.yml Outdated Show resolved Hide resolved
.github/workflows/terraform-compatibility-matrix.yml Outdated Show resolved Hide resolved
scripts/get-terraform-supported-versions.sh Outdated Show resolved Hide resolved
scripts/get-terraform-supported-versions.sh Outdated Show resolved Hide resolved
scripts/get-terraform-supported-versions.sh Show resolved Hide resolved
oarbusi and others added 6 commits March 14, 2024 17:48
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
@oarbusi oarbusi changed the title feat: Schedules run of acceptance and migration tests for all HashiCorp Terraform supported versions chore: Schedules run of acceptance and migration tests for all HashiCorp Terraform supported versions Mar 15, 2024
shell: bash
id: get-terraform-supported-versions
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

@lantoli lantoli Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this GITHUB_TOKEN needed?

Copy link
Collaborator Author

@oarbusi oarbusi Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, GitHub API has rate limiting and with the github token limits are increased, so the script does not fail

Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no blocker but I recommend to add output info in the script (e.g. sorted list of all X.X.0 HC releases including the ones already out of support with published and end-of-support dates) so it's easier to see any issue that could happen. (that would probably imply to get the script result in GH action using an exported variable instead of the output)

@oarbusi oarbusi merged commit 71f86c5 into master Mar 15, 2024
45 checks passed
@oarbusi oarbusi deleted the CLOUDP-219140 branch March 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants