-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Schedules run of acceptance and migration tests for all HashiCorp Terraform supported versions #2012
Conversation
This reverts commit 676fa4a.
…passing environment
|
||
on: | ||
schedule: | ||
- cron: "0 0 * * 6" # runs every Saturady at midnight UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we're doing it weekly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this before putting it in review. Now it's fixed, will run on first Saturday of every month
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
Co-authored-by: Andrea Angiolillo <andrea.angiolillo@mongodb.com>
shell: bash | ||
id: get-terraform-supported-versions | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this GITHUB_TOKEN needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, GitHub API has rate limiting and with the github token limits are increased, so the script does not fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no blocker but I recommend to add output info in the script (e.g. sorted list of all X.X.0 HC releases including the ones already out of support with published and end-of-support dates) so it's easier to see any issue that could happen. (that would probably imply to get the script result in GH action using an exported variable instead of the output)
Description
Schedule run of acceptance and migration tests for all supported versions of HashiCorp Terraform
Example Run (failed because it was manually cancelled to avoid consuming too many resources)
Link to any related issue(s): CLOUDP-219140
Type of change:
Required Checklist:
Further comments