refactor: Uses mocks on admin.APIClient instead of custom ClusterService #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrocki
approved these changes
Mar 21, 2024
lantoli
reviewed
Mar 21, 2024
Comment on lines
-1
to
-2
| // Code generated by mockery. DO NOT EDIT. | ||
|
|
There was a problem hiding this comment.
should we also adjust the mockery configuration? surprised our CI check "Mock generation" did not catch this, but maybe it is because the interface has been removed.
There was a problem hiding this comment.
I think so, that file doesn't exist any more
lantoli
reviewed
Mar 21, 2024
| GroupId: projectID, | ||
| } | ||
| clusters, resp, err := client.List(ctx, params) | ||
| clusters, resp, err := client.ListClusters(ctx, projectID).Execute() |
There was a problem hiding this comment.
what is the difference beetween List and ListClusters? do they return the same thing just passing the params differently?
There was a problem hiding this comment.
func (a *ClusterServiceFromClient) List(ctx context.Context, options *admin.ListClustersApiParams) (*admin.PaginatedAdvancedClusterDescription, *http.Response, error) {
return a.client.ClustersApi.ListClustersWithParams(ctx, options).Execute()👆 This was the old code in the service_advanced_cluster.go. (only named List)
I preferred using ListClusters instead of ListClustersWithParams since the ListClustersApiParams only used GroupId in the admin.ListClustersApiParams
lantoli
approved these changes
Mar 21, 2024
marcosuma
approved these changes
Mar 21, 2024
oarbusi
pushed a commit
that referenced
this pull request
Mar 22, 2024
oarbusi
added a commit
that referenced
this pull request
Mar 22, 2024
…ted (#2052) * schedule compatibility matrix first day of month * WIP: test if status can be retrieved * test * test echo job status * change * Revert "change" This reverts commit 4b0e49e. * Revert "test echo job status" This reverts commit 4a83862. * test getting outputs of matrix * result * send slack * checkout step * fix name * correct json * formating * Revert "formating" This reverts commit f584822. * format * try * Revert "try" This reverts commit 7029f54. * use cat * Revert "use cat" This reverts commit 9503cd2. * remove unnecesary double quote * try cat * Revert "try cat" This reverts commit a2df8ff. * return json * unify json * fix * enrich message * TEMP: tag oncall on success * chore: Updates Atlas Go SDK (#2044) * build(deps): bump go.mongodb.org/atlas-sdk * fix tags * undo changes to admin20231001002 * API breaking change fixes --------- Co-authored-by: lantoli <430982+lantoli@users.noreply.github.com> * chore: Follow-up to Atlas SDK upgrade (#2051) * remove unused NewGroup * unify List call thanks to new API * refactor: Uses mocks on admin.APIClient for Project+Teams+ClustersAPIs instead of custom service (#2045) * refactor: Uses mocks on admin.APIClient instead of custom ClusterService (#2056) * fix: Fixes `network_container` resource update (#2055) * failing test * recreate resource if provider_name changes * fix update * allow update in place when provider_name changes * fix regions error handling * refactor tests checks * refactor checks in mig tests as well * fix change check * use MONGODB_ATLAS_PROJECT_ID (#2060) * chore: Removes old service from mockery (#2063) * feat: Allows user to specify to use an existing tag for release (#2053) * remove TEMP oncall tag on success * initialize oncall_tag * send notification when test suite fails * revert back testing change * remove temporary trigger of action * use oncall tag from secrets * Revert "use oncall tag from secrets" This reverts commit 5a7944f. * use SHA * new line * make oncall tag a secret --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: lantoli <430982+lantoli@users.noreply.github.com> Co-authored-by: Espen Albert <EspenAlbert@users.noreply.github.com> Co-authored-by: maastha <122359335+maastha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses mocks on admin.APIClient instead of custom ClusterService
Link to any related issue(s): CLOUDP-237016
Type of change:
Required Checklist:
Further comments