chore: Reuses project in tests - project #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
force-pushed
the
CLOUDP-239550_project
branch
from
8cb86a0
to
a864c51
Compare
AgustinBettati
approved these changes
Mar 26, 2024
Comment on lines
+509
to
+514
| commonChecks := map[string]string{ | ||
| "name": projectName, | ||
| "org_id": orgID, | ||
| "cluster_count": "0", | ||
| "teams.#": "2", | ||
| } |
There was a problem hiding this comment.
could we add a check for limits attribute as well? seeing that it was tested in the data source tests
There was a problem hiding this comment.
sure, i'll do in the limit test
oarbusi
approved these changes
Mar 26, 2024
lantoli
commented
Mar 26, 2024
| var ( | ||
| orgID = os.Getenv("MONGODB_ATLAS_ORG_ID") | ||
| projectName = acc.RandomProjectName() | ||
| limitChecks = []map[string]string{ |
There was a problem hiding this comment.
@AgustinBettati ds limit tests
maastha
approved these changes
Mar 26, 2024
AgustinBettati
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reuses project in tests - project.
Moves data source tests with resource tests.
Link to any related issue(s): CLOUDP-239550
Type of change:
Required Checklist:
Further comments