Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Specifies that upgrades From Replica Sets to Multi-Sharded Instances of cluster and advanced cluster might lead to error #2080

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

oarbusi
Copy link
Collaborator

@oarbusi oarbusi commented Mar 26, 2024

Description

Specifies that Upgrades From Replica Sets to Multi-Sharded Instances might lead to error

Link to any related issue(s): CLOUDP-237821

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@@ -424,7 +424,8 @@ replication_specs {

**Replication Spec** - Configuration block for multi-region cluster.

* `num_shards` - (Required) Number of shards to deploy in the specified zone, minimum 1.
* `num_shards` - (Required) Number of shards up to 50 to deploy for a sharded cluster. The resource returns 1 to indicate a replica set and values of 2 and higher to indicate a sharded cluster. The returned value equals the number of shards in the cluster.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating the description of the field to align with API docs

@oarbusi oarbusi marked this pull request as ready for review March 26, 2024 10:55
@oarbusi oarbusi requested a review from a team as a code owner March 26, 2024 10:55
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oarbusi oarbusi merged commit 09dc5c6 into master Mar 27, 2024
48 checks passed
@oarbusi oarbusi deleted the CLOUDP-237821 branch March 27, 2024 08:44
lantoli added a commit that referenced this pull request Apr 1, 2024
* master:
  test: Introduces shared cluster resource for running search index tests (#2086)
  doc: Generates v1.15.3 (#2095)
  chore: Bump github.com/zclconf/go-cty from 1.14.3 to 1.14.4 (#2089)
  chore: Bump github.com/mongodb-forks/digest from 1.0.5 to 1.1.0 (#2087)
  chore: Bump github.com/hashicorp/hcl/v2 from 2.20.0 to 2.20.1 (#2091)
  chore: Bump tj-actions/verify-changed-files (#2092)
  chore: Bump github.com/aws/aws-sdk-go from 1.51.3 to 1.51.8 (#2088)
  test: Converting a test case to a migration test (#2081)
  chore: Fixes Slack notification button to GH action run text (#2093)
  doc: Specifies that upgrades From Replica Sets to Multi-Sharded Instances of cluster and advanced cluster might lead to error (#2080)
  doc: Fixes import command in third_party_integration doc (#2083)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants