Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds global_cluster_self_managed_sharding to mongodbatlas_advanced_cluster resource #2348

Merged
merged 8 commits into from
Jun 19, 2024
Merged

feat: Adds global_cluster_self_managed_sharding to mongodbatlas_advanced_cluster resource #2348

merged 8 commits into from
Jun 19, 2024

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Jun 17, 2024 •
edited
Loading

Description

Adds global_cluster_self_managed_sharding to mongodbatlas_advanced_cluster resource and corresponding data sources.

Link to any related issue(s): CLOUDP-256265

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@lantoli lantoli marked this pull request as ready for review June 18, 2024 10:17
@lantoli lantoli requested review from a team as code owners June 18, 2024 10:17
@github-actions GitHub Actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

@lantoli lantoli mentioned this pull request Jun 18, 2024
Merged
19 tasks
EspenAlbert
EspenAlbert reviewed Jun 18, 2024
View reviewed changes
internal/service/advancedcluster/resource_advanced_cluster_test.go
resource.TestCheckResourceAttrSet(dataSourcePluralName, "results.#"),
resource.TestCheckResourceAttrSet(dataSourcePluralName, "results.0.replication_specs.#"),
resource.TestCheckResourceAttrSet(dataSourcePluralName, "results.0.name"),
resource.TestCheckResourceAttrSet(dataSourcePluralName, "results.0.termination_protection_enabled"),
resource.TestCheckResourceAttrSet(dataSourcePluralName, "results.0.global_cluster_self_managed_sharding"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to see these checks refactored 😅

Copy link
Member Author

@lantoli lantoli Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, ticket created to do it in a following PR: https://jira.mongodb.org/browse/CLOUDP-256561

EspenAlbert
EspenAlbert approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@EspenAlbert EspenAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Only some knit comments :D

maastha
maastha reviewed Jun 18, 2024
View reviewed changes
internal/service/advancedcluster/resource_advanced_cluster_test.go Outdated
numShardsUpdated = "2"
orgID = os.Getenv("MONGODB_ATLAS_ORG_ID")
projectName = acc.RandomProjectName()
clusterName = acc.RandomClusterName() // No ProjectIDExecution to avoid cross-region limits because multi-region
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this comment be on the line above? same for the other test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, changed

maastha
maastha reviewed Jun 18, 2024
View reviewed changes
internal/service/advancedcluster/resource_advanced_cluster_test.go Outdated
name = %[2]q

cluster_type = "REPLICASET"
global_cluster_self_managed_sharding = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could we add a small comment here why this config is incorrect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, comment added

erabil-mdb
erabil-mdb approved these changes Jun 18, 2024
View reviewed changes
Copy link

@erabil-mdb erabil-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lantoli lantoli merged commit 0085b85 into master Jun 19, 2024
33 of 35 checks passed
@lantoli lantoli deleted the CLOUDP-256265_global_cluster branch June 19, 2024 06:28
svc-apix-Bot added a commit that referenced this pull request Jun 19, 2024
@svc-apix-Bot
chore: Updates CHANGELOG.md for #2348
3bf7b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha left review comments

@EspenAlbert EspenAlbert EspenAlbert approved these changes

@Zuhairahmed Zuhairahmed Zuhairahmed approved these changes

@erabil-mdb erabil-mdb erabil-mdb approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lantoli @EspenAlbert @Zuhairahmed @erabil-mdb @maastha