Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve usage of test_name in the Acceptance test workflow #2353

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

maastha
Copy link
Collaborator

@maastha maastha commented Jun 18, 2024

Description

This PR improves usage of test_name in the Acceptance test workflow .

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@maastha maastha changed the title chore: cleanup chore: Improve usage of test_name in the Acceptance test workflow Jun 18, 2024
@maastha maastha marked this pull request as ready for review June 18, 2024 16:56
@maastha maastha requested a review from a team as a code owner June 18, 2024 16:56
Copy link
Member

@lantoli lantoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

I have done a few executions to double-check the 3 conditions in ACCTEST_REGEX_RUN:

@lantoli
Copy link
Member

lantoli commented Jun 18, 2024

knit: these two lines can be reverted:

mustTrigger: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.test_group == '' && inputs.test_name == '')  }}

if: ${{ inputs.test_group == '' && inputs.test_name == '' && env.mustTrigger == 'false' }}

to the previous version without test_name:

mustTrigger: ${{ github.event_name == 'schedule' || (github.event_name == 'workflow_dispatch' && inputs.test_group == '' )  }}

if: ${{ inputs.test_group == ''  && env.mustTrigger == 'false' }}

We're saying that when using test_name a test_group must be specified, so if we're not using a test_group ( inputs.test_group == '') then we're sure that test_name is empty, no need to check it

@maastha maastha merged commit 333dcf9 into master Jun 18, 2024
101 checks passed
@maastha maastha deleted the update-acc-test-workflow-cleanup branch June 18, 2024 19:50
@EspenAlbert
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants