Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: team datasource add team name option #253

Merged
merged 4 commits into from Jun 29, 2020
Merged

imp: team datasource add team name option #253

merged 4 commits into from Jun 29, 2020

Conversation

gmlp
Copy link
Contributor

@gmlp gmlp commented Jun 24, 2020 •
edited

Description

Improves team Datasource

  • add team name option

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirments
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@ghost ghost added the size/S label Jun 24, 2020
@ghost ghost added the documentation label Jun 24, 2020
themantissa
themantissa requested changes Jun 25, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo noted in comment (and tests failing), otherwise LGTM so can approved once fixed!

website/docs/d/team.html.markdown Outdated Show resolved Hide resolved
PacoDw
PacoDw suggested changes Jun 25, 2020
View reviewed changes
mongodbatlas/data_source_mongodbatlas_team.go Outdated Show resolved Hide resolved
mongodbatlas/data_source_mongodbatlas_team_test.go Show resolved Hide resolved
website/docs/d/team.html.markdown Show resolved Hide resolved
website/docs/d/team.html.markdown Show resolved Hide resolved
@ghost ghost added size/M and removed size/S labels Jun 26, 2020
@gmlp gmlp requested review from themantissa and PacoDw June 26, 2020 17:11
themantissa
themantissa approved these changes Jun 26, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlp gmlp merged commit cfdd80b into master Jun 29, 2020
@themantissa themantissa deleted the improve-team-data-source branch August 10, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@PacoDw PacoDw PacoDw approved these changes

@marinsalinas marinsalinas Awaiting requested review from marinsalinas

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmlp @themantissa @PacoDw