Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-133: Vendor removal to include terratest samples #395

Merged
merged 2 commits into from Feb 5, 2021

Conversation

leofigy
Copy link
Contributor

@leofigy leofigy commented Jan 27, 2021

Description

Context: The provider initially created used the vendor folder. However due to the go modules introduction, there is no longer the need to have the vendor folder. Now we will start introducing terratest so keeping the vendor folder is not an option.

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@leofigy leofigy changed the title vendor removal experiment: vendor removal Jan 27, 2021
@leofigy leofigy added the run-testacc To run acceptance tests label Jan 27, 2021
@leofigy leofigy changed the title experiment: vendor removal INTMDB-133: Vendor removal to include terratest samples Feb 4, 2021
@leofigy leofigy self-assigned this Feb 4, 2021
@leofigy leofigy added dependencies v0.9.0 and removed run-testacc To run acceptance tests v0.9.0 labels Feb 4, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this important clean up work!

Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works then LGTM!!, thank you

@leofigy leofigy merged commit 259172d into master Feb 5, 2021
@leofigy leofigy deleted the vendor-removal branch February 5, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants