-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network peering #43
Network peering #43
Conversation
…iting time was reduced fix: add errorContainerDelete to delete func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check the make lint
issue?
@marinsalinas this appears:
Maybe is regarding this issue: golangci/golangci-lint#308 |
you should run The lint error is the following:
|
3151119
to
6e59f47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Waiting for @themantissa review to merge it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving (if my slack comment to you about how this flows is right). It's a very nice way to handle this!
atlas_gcp_project_id
andatlas_vpc_name
to peering state to be more easy the flow.You can use the following configuration to create the reciprocal connection:
closes #29 , #41