Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starter example improvements and doc update #474

Merged
merged 2 commits into from Jun 15, 2021
Merged

Starter example improvements and doc update #474

merged 2 commits into from Jun 15, 2021

Conversation

themantissa
Copy link
Collaborator

@themantissa themantissa commented Jun 10, 2021 •
edited

Description

-Updated the doc index to point to the examples directory
-Added a few more variables and such to the starter example that seemed useful after writing a demo using it.

Link to any related issue(s):
#469

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • [x ] I have signed the MongoDB CLA
  • [ x] I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • [x ] I have added any necessary documentation (if appropriate)
  • [ x] I have run make fmt and formatted my code

Further comments

@themantissa
Starter example improvements and doc update
56a32f5 
-Updated the doc index to point to the examples directory
-Added a few more variables and such to the starter example that seemed useful after writing a demo using it.
@themantissa
Copy link
Collaborator Author

@nikhil-mongo can you give this a quick look?

nikhil-mongo
nikhil-mongo approved these changes Jun 15, 2021
View reviewed changes
Copy link
Collaborator

@nikhil-mongo nikhil-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit b0dd7f4 into master Jun 15, 2021
@themantissa themantissa deleted the General-doc-and-example-updates branch June 15, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil-mongo nikhil-mongo nikhil-mongo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@themantissa @nikhil-mongo