INTMDB-233: Update linter version #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiBojin
requested review from
abner-dou,
andreaangiolillo,
coderGo93 and
themantissa
as code owners
gssbzn
reviewed
Aug 5, 2021
.golangci.yml
Outdated
| @@ -10,7 +10,7 @@ linters-settings: | |||
| - octalLiteral | |||
| govet: | |||
| check-shadowing: true | |||
| golint: | |||
| revive: | |||
| min-confidence: 0 | |||
There was a problem hiding this comment.
min-confidence is not a valid revive setting, https://github.com/mgechev/revive#configuration
Feel free to check the cli but we have some extra rules that don't come enabled by default
mongodbatlas/data_source_mongodbatlas_third_party_integration_test.go
Outdated
Show resolved
Hide resolved
MihaiBojin
commented
Aug 5, 2021
|
|
||
| export PATH := ./bin:$(PATH) | ||
| export PATH := $(shell go env GOPATH)/bin:$(PATH) | ||
| export SHELL := env PATH=$(PATH) /bin/bash |
There was a problem hiding this comment.
This line is required to use the PATH on MacOS
|
LGTM! |
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments