Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-237: fix word in private_endpoint resource documentation #523

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

abner-dou
Copy link
Contributor

@abner-dou abner-dou commented Aug 19, 2021

Description

Changed providerName ->. provider_name in documentation. This word was searched in other documentation files but, the error was only in the resource documentation

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@themantissa themantissa requested review from a team and gssbzn and removed request for a team August 19, 2021 23:26
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themantissa themantissa merged commit fced21d into master Aug 25, 2021
@themantissa themantissa deleted the INTMDB-237 branch August 25, 2021 14:52
abner-dou added a commit to abner-dou/terraform-provider-mongodbatlas that referenced this pull request Aug 25, 2021
themantissa pushed a commit that referenced this pull request Aug 26, 2021
* fixed documentattion

* fix documentation

* typo fix

* changed examples in documentation

* added deprecated tags

* fix conflicts

* docs: added other example for ldap configuration docs (#520)

Co-authored-by: Edgar Lopez <edgarlopez@pop-os.localdomain>

* fix documentation word in resources (#523)

* feat: use golangci lint action (#528)

* task: remove misspell as a dependency (#527)

* task: check examples are formatted correctly (#529)

* INTMDB-236: Updated the cluster configuration (#526)

* refactor: refactorized the examples for the cluster in tests/docs/examples

* comment

Co-authored-by: Edgar Lopez <edgarlopez@pop-os.localdomain>

* fix deprecated docs

Co-authored-by: Edgar López <edgars.ealo@gmail.com>
Co-authored-by: Edgar Lopez <edgarlopez@pop-os.localdomain>
Co-authored-by: Gustavo Bazan <gssbzn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants