-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-230: added property to maintenance window rs ds #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix failing tests before asking for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small docs edit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change again but not you - just trying to make sure it matches the docs as these are so close it's hard to tell them apart! Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the doc edits :)
* added property to maintenance window rs ds * changed go.mod * fix go.sum * fixes lint * fix go.sum * fix maintenance window documentation * fix maintenance window resource documentation
Description
Added
auto_defer_once_enabled
property tomaintenance_window
resource and datasourceLink to any related issue(s):INTMDB-230
Type of change:
Required Checklist:
Further comments
this PR is related to mongodb/go-client-mongodb-atlas#249 (changes to go-client)
Test results: