Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-230: added property to maintenance window rs ds #552

Merged
merged 8 commits into from
Sep 29, 2021
Merged

Conversation

abner-dou
Copy link
Contributor

@abner-dou abner-dou commented Sep 1, 2021

Description

Added auto_defer_once_enabled property to maintenance_window resource and datasource

Link to any related issue(s):INTMDB-230

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

this PR is related to mongodb/go-client-mongodb-atlas#249 (changes to go-client)

Test results:

-----------------------------------------------------
--- PASS: TestAccResourceMongoDBAtlasMaintenanceWindow_basic (7.23s)
PASS
coverage: 3.0% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 9.596s  coverage: 3.0% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]


-----------------------------------------------------
--- PASS: TestAccResourceMongoDBAtlasMaintenanceWindow_importBasic (4.48s)
PASS
coverage: 2.8% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 6.694s  coverage: 2.8% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]


-----------------------------------------------------
--- PASS: TestAccResourceMongoDBAtlasMaintenanceWindow_autoDeferActivated (4.04s)
PASS
coverage: 2.8% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 6.330s  coverage: 2.8% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]


-----------------------------------------------------
--- PASS: TestAccDataSourceMongoDBAtlasMaintenanceWindow_basic (5.11s)
PASS
coverage: 3.0% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 7.471s  coverage: 3.0% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests before asking for review

Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small docs edit.

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change again but not you - just trying to make sure it matches the docs as these are so close it's hard to tell them apart! Thank you :)

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the doc edits :)

@abner-dou abner-dou merged commit c008f6f into master Sep 29, 2021
@abner-dou abner-dou deleted the INTMDB-230 branch September 29, 2021 15:46
abner-dou added a commit that referenced this pull request Oct 7, 2021
* added  property to maintenance window rs ds

* changed go.mod

* fix go.sum

* fixes lint

* fix go.sum

* fix maintenance window documentation

* fix maintenance window resource documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants