Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-252: Added two parameters for cluster advanced configuration #558

Merged
merged 9 commits into from
Sep 15, 2021

Conversation

coderGo93
Copy link
Contributor

Description

  • Added two parameters called default_read_concern and default_write_concern for cluster under advanced_configuration
  • Added test TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf
  • Passed nil for create a project

Results of TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf

 make testacc TESTARGS='-run=TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... | grep -v /integrationtesting) -v -parallel 20 -run=TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf -timeout 300m -cover -ldflags="-s -w -X 'github.com/mongodb/terraform-provider-mongodbatlas/version.ProviderVersion=acc'"
?       github.com/mongodb/terraform-provider-mongodbatlas      [no test files]
=== RUN   TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf
=== PAUSE TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf
=== CONT  TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf
--- PASS: TestAccResourceMongoDBAtlasCluster_basic_DefaultWriteRead_AdvancedConf (767.71s)
PASS
coverage: 8.2% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 768.020s        coverage: 8.2% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mongodbatlas/resource_mongodbatlas_cluster_test.go Outdated Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_cluster_test.go Outdated Show resolved Hide resolved
@coderGo93 coderGo93 added the run-testacc To run acceptance tests label Sep 13, 2021
@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Sep 14, 2021
@thetonymaster thetonymaster merged commit 2d5ff92 into master Sep 15, 2021
@thetonymaster thetonymaster deleted the INTMDB-252 branch September 15, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants