INTMDB-211: Add new advanced shard key options in global cluster resource #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abner-dou
requested review from
gssbzn,
themantissa,
thetonymaster and
coderGo93
mongodbatlas/resource_mongodbatlas_global_cluster_config_test.go
Outdated
Show resolved
Hide resolved
| addManagedNamespace.IsCustomShardKeyHashed = pointy.Bool(isCustomShardKeyHashed.(bool)) | ||
| } | ||
|
|
||
| if isShardKeyUnique, okShard := mn["is_shard_"]; okShard { |
There was a problem hiding this comment.
this is incomplete right? is_shard_
| addManagedNamespace.IsCustomShardKeyHashed = pointy.Bool(isCustomShardKeyHashed.(bool)) | ||
| } | ||
|
|
||
| if isShardKeyUnique, okShard := mn["is_shard_"]; okShard { |
There was a problem hiding this comment.
is this being tested? it seems it is incomplete
There was a problem hiding this comment.
yes, It was incomplete
mongodbatlas/resource_mongodbatlas_global_cluster_config_test.go
Outdated
Show resolved
Hide resolved
thetonymaster
approved these changes
Sep 20, 2021
abner-dou
added a commit
that referenced
this pull request
Oct 7, 2021
…urce (#562) * Added is_custom_shard_key_hashed and is_shard_key_unique to cluster config * fixed tests * added documentation * fix dep * fixes * go.mod changed * fixed test format * added tests * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
isCustomShardKeyHashedandisShardKeyUniqueproperties to RS and DS for Global_clusterLink to any related issue(s):INTMDB-211
Type of change:
Required Checklist:
Further comments
Tests:
--- PASS: TestAccResourceMongoDBAtlasGlobalCluster_basic (662.26s)
PASS
coverage: 8.3% of statements
ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 664.729s coverage: 8.3% of statements
? github.com/mongodb/terraform-provider-mongodbatlas/version [no test files]