Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-256: Fixes a bug for updated a role in cloud access authorization #567

Merged
merged 2 commits into from
Sep 27, 2021
Merged

INTMDB-256: Fixes a bug for updated a role in cloud access authorization #567

merged 2 commits into from
Sep 27, 2021

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Sep 22, 2021 •
edited

Description

  • Migrated the aws with a state migrator because it was mistaken as deprecated, since it's already released with sdk migration, a state migrator it's better idea instead of deprecated this time in case if some user has been using the resource in 0.9.1 and upgraded to 1.0.0 or newer
  • Fixed a bug when it wants to update a role in cloud access authorization
  • Added a test to show it passes, see below for the result

Result of test

--- PASS: TestAccResourceMongoDBAtlasCloudProviderAccessAuthorization_basic (50.89s)
PASS
coverage: 4.2% of statements
ok      github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 50.943s coverage: 4.2% of statements
?       github.com/mongodb/terraform-provider-mongodbatlas/version      [no test files]

Link to any related issue(s):
#565 #554

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

INTMDB-255 is related to this PR because of the same error

@coderGo93 coderGo93 self-assigned this Sep 22, 2021
themantissa
themantissa approved these changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

andreaangiolillo
andreaangiolillo approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderGo93 coderGo93 added run-testacc To run acceptance tests and removed run-testacc To run acceptance tests labels Sep 24, 2021
@thetonymaster thetonymaster merged commit 3ef0491 into master Sep 27, 2021
@thetonymaster thetonymaster deleted the INTMDB-256 branch September 27, 2021 15:37
abner-dou pushed a commit that referenced this pull request Oct 7, 2021
@coderGo93 @abner-dou
INTMDB-256: Fixes a bug for updated a role in cloud access authorizat…
1a37a12 
…ion (#567)

* fix: migrated aws parameter and fixed a bug with a test

* added skip test cred because of aws

Co-authored-by: Edgar Lopez <edgarlopez@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@abner-dou abner-dou Awaiting requested review from abner-dou

Assignees

@coderGo93 coderGo93

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@coderGo93 @themantissa @thetonymaster @andreaangiolillo