Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTMDB-254: Fix replication_specs behaviour when update cluster #573

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

abner-dou
Copy link
Contributor

Description

A validation was re-coded in replication_specs cluster to get the original id when update the cluster

Link to any related issue(s):INTMDB-254

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

TEST:

--- PASS: TestAccResourceMongoDBAtlasCluster_MultiRegion (1572.79s)
PASS
coverage: 8.1% of statements
ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 1575.224s coverage: 8.1% of statements
? github.com/mongodb/terraform-provider-mongodbatlas/version [no test files]

@abner-dou abner-dou added the run-testacc To run acceptance tests label Sep 28, 2021
@abner-dou abner-dou self-assigned this Sep 28, 2021
@abner-dou abner-dou changed the title fix replication_specs behaviour when update cluster INTMDB-254: Fix replication_specs behaviour when update cluster Sep 28, 2021
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for knocking this out quickly (also tests haven't passed yet but will check again before merge - still two approvers to go)

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-testacc To run acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INVALID_CLUSTER_CONFIGURATION when adding new regions
4 participants