Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-203: Fix IOPS restriction on NVME clusters #574

Merged
merged 5 commits into from
Oct 1, 2021
Merged

INTMDB-203: Fix IOPS restriction on NVME clusters #574

merged 5 commits into from
Oct 1, 2021

Conversation

abner-dou
Copy link
Contributor

Description

A restriction was added to cluster when try to update a cluster to an NVME instance and avoid to send the IOPS parameter to the API

Link to any related issue(s):INTMDB-203

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

TEST:

--- PASS: TestAccResourceMongoDBAtlasCluster_basicAWS_instanceScale (2643.25s)
PASS
coverage: 7.5% of statements
ok github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2645.655s coverage: 7.5% of statements
? github.com/mongodb/terraform-provider-mongodbatlas/version [no test files]

@abner-dou abner-dou added the run-testacc To run acceptance tests label Sep 29, 2021
@abner-dou abner-dou self-assigned this Sep 29, 2021
andreaangiolillo
andreaangiolillo approved these changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but tests are failing though.

thetonymaster
thetonymaster approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@thetonymaster thetonymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just check the tests

@themantissa
Copy link
Collaborator

@abner-dou fyi test failed and last review needed is from DoU.

themantissa
themantissa approved these changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abner-dou abner-dou merged commit f712520 into master Oct 1, 2021
@abner-dou abner-dou deleted the INTMDB-203 branch October 1, 2021 12:55
abner-dou added a commit that referenced this pull request Oct 7, 2021
@abner-dou
INTMDB-203: Fix IOPS restriction on NVME clusters (#574)
6d34432 
* restrict iops parameter in nvme instance size

* fix lint

* fixes

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees

@abner-dou abner-dou

Labels
run-testacc To run acceptance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abner-dou @themantissa @thetonymaster @andreaangiolillo