Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-313: Set project settings to computed to ignore when not supplied by user #778

Merged
merged 3 commits into from Jul 8, 2022
Merged

INTMDB-313: Set project settings to computed to ignore when not supplied by user #778

merged 3 commits into from Jul 8, 2022

Conversation

martinstibbe
Copy link
Contributor

@martinstibbe martinstibbe commented Jul 7, 2022 •
edited

Description

Set project settings to computed to ignore when not supplied by user

Link to any related issue(s):
#741

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@wyardley
Copy link

wyardley commented Jul 8, 2022

#777

colm-quinn
colm-quinn approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@colm-quinn colm-quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@martinstibbe martinstibbe merged commit a7edace into master Jul 8, 2022
@martinstibbe martinstibbe deleted the INTMDB-313 branch July 29, 2022 02:06
guineveresaenger pushed a commit to pulumi/terraform-provider-mongodbatlas that referenced this pull request Sep 13, 2022
@martinstibbe @guineveresaenger
INTMDB-313: Set project settings to computed to ignore when not suppl…
cec1152 
…ied by user (mongodb#778)

* Set project settings to computed to ignore when not supplied by user

* Update CHANGELOG.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colm-quinn colm-quinn colm-quinn approved these changes

@themantissa themantissa themantissa approved these changes

@andreaangiolillo andreaangiolillo Awaiting requested review from andreaangiolillo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martinstibbe @wyardley @colm-quinn @themantissa