-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INTMDB-404: mongodbatlas_advanced_cluster doc updates #852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adjust the statement a bit. Gave example
looks good Co-authored-by: Melissa Plunkett <themantissa@users.noreply.github.com>
@martinstibbe can you review as well so we can get 2 reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause the value of instance_size
returned to potentially be different than what is specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to click the circle next to my name when a PR is ready for re-review or I won't get alerted. Thanks!
This will cause the value of `instance_size` returned to potential be different than what is specified in the Terraform config and if one then applies a plan, not noting this, Terraform will scale the cluster back down to the original `instance_size` value. | ||
To prevent this a lifecycle customization should be used, i.e.: | ||
`lifecycle { | ||
ignore_changes = [instance_size] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zuhairahmed @martinstibbe Hi,
Maybe I'm wrong, but I can't include a nested attribute into ignore_changes
For example,
#...
lifecycle {
# as autoscaling is enabled
ignore_changes = [
disk_size_gb,
instance_size
]
}
terraform plan
╷
│ Error: Unsupported attribute
│
│ on mongodb_atlas_cluster.tf line 72, in resource "mongodbatlas_advanced_cluster" "product":
│ 72: instance_size
│
│ This object has no argument, nested block, or exported attribute named "instance_size".
✗ terraform version
Terraform v1.2.9
on darwin_arm64
+ provider registry.terraform.io/mongodb/mongodbatlas v1.5.0
More details - #888
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @ivan-sukhomlyn, we are actively working on this issue and should have update out to correct this behavior as part of v1.7 release in a few weeks time. Internal ticket INTMDB-464
Description
Updates to Resource: mongodbatlas_advanced_cluster to include warning for auto scaling compute enabled as well minor doc bug fix to Data Source: mongodbatlas_advanced_cluster (erroneous output at top of page)
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments