Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMD-428: doc update to "mongodbatlas_projects" #869

Merged
merged 1 commit into from
Oct 24, 2022
Merged

INTMD-428: doc update to "mongodbatlas_projects" #869

merged 1 commit into from
Oct 24, 2022

Conversation

Zuhairahmed
Copy link
Collaborator

@Zuhairahmed Zuhairahmed commented Oct 12, 2022 •
edited

Description

Doc bug fix - #867

Updated example to include "s" in mongodbatlas_projects

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@Zuhairahmed Zuhairahmed changed the title Update projects.html.markdown INTMD-428: doc update to "mongodbatlas_projects" Oct 12, 2022
@Zuhairahmed Zuhairahmed mentioned this pull request Oct 12, 2022
Closed
@martinstibbe martinstibbe self-requested a review October 12, 2022 19:06
martinstibbe
martinstibbe approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashraidiam
Copy link

@Zuhairahmed I have raised a carbon copy issue, looks like the issue might be wider spread.
#879

themantissa
themantissa approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge now.

@themantissa themantissa merged commit 791e2dc into mongodb:master Oct 24, 2022
@Zuhairahmed Zuhairahmed deleted the INTMDB-428 branch November 7, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@martinstibbe martinstibbe martinstibbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zuhairahmed @ashraidiam @themantissa @martinstibbe