feat: add collation support #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsalvata
force-pushed
the
jordi/support-collations
branch
3 times, most recently
from
9f2d53e
to
69afcc7
Compare
skeggse
approved these changes
Dec 10, 2019
|
🎉 |
wearhere
reviewed
Dec 10, 2019
| @@ -8,7 +8,7 @@ class Cursor extends Readable { | |||
|
|
|||
| // Currently mongodb cursor options itcount, readPref, showDiskLoc are not implemented - and some other | |||
| // See https://docs.mongodb.com/manual/reference/method/js-cursor/ | |||
| const operations = ['batchSize', 'hint', 'limit', 'maxTimeMS', 'max', 'min', 'skip', 'snapshot', 'sort'] | |||
| const operations = ['batchSize', 'hint', 'limit', 'maxTimeMS', 'max', 'min', 'skip', 'snapshot', 'sort', 'collation']; | |||
There was a problem hiding this comment.
Can we document this somewhere? Looks like https://github.com/mongoist/mongoist#cursor might list the other options here.
There was a problem hiding this comment.
Good place to note that it's only supported on 3.4 and up too.
jsalvata
force-pushed
the
jordi/support-collations
branch
from
7705ed5
to
150f826
Compare
jsalvata
force-pushed
the
jordi/support-collations
branch
from
150f826
to
1f376ed
Compare
wearhere
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for collations so we can, for example, sort in alphabeticall order with 'b' < 'C' (rather than MongoDB's default binary ordering which makes 'a' > 'Z').